-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quantum conditional entropy example #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 89 89
Lines 5150 5152 +2
=======================================
+ Hits 5052 5054 +2
Misses 98 98 ☔ View full report in Codecov by Sentry. |
ericphanson
commented
May 18, 2024
docs/src/examples/optimization_with_complex_variables/quantum_conditional_entropy.jl
Outdated
Show resolved
Hide resolved
…conditional_entropy.jl
Yes, I think @blegat has a plan for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the second example from #418 (comment)
I thought it could be nice to have some examples using some of the CVXQUAD functionality. I put in a lot of quantum information theory preliminaries, but maybe we could trim some back if it's too much.
This example originally had 23s of formulation time and 4s solve time. I profiled and found
permutedims_matrix
was very slow and allocating (and it gets used a lot, since it is used fortranspose
and thus forvcat
). I was able to optimize it by constructing the sparse matrix directly (in COO format). Now we have 3s formulation time and the same 4s solve time, which seems much more acceptable (maybe a little slow still, but I didn't see any other low hanging fruit).BTW, here the reformulations and bridges really blow up the problem size:
using
I think Hypatia can be used to avoid some of the reformulations; I guess to hook everything up, we would need to move the sets to MOI and update Hypatia to support them directly (?).